fix: resolve Windows path issue in pnpm build client #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx, this is it Windows requires: "extract-version": "version.sh" |
odilitime
approved these changes
Jan 14, 2025
This was referenced Jan 24, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2223
Relates to
#2223
Risks
Background
What does this PR do?
Windows users are experiencing an issue with the
extract-versionscript in package.json. The current configuration works differently on Windows vs Unix-based systems:"extract-version": "version.sh""extract-version": "./version.sh"This is causing the script to fail on Windows systems due to path resolution differences between operating systems.
Solution
The most cross-platform compatible solution is to use the
shcommand explicitly in the scriptWhat kind of change is this?
Documentation changes needed?
Testing
Where should a reviewer start?
Detailed testing steps